On 12/14/23 11:54, Arnd Bergmann wrote: > On Thu, Dec 7, 2023, at 01:21, Jiaxun Yang wrote: >> 在2023年12月6日十二月 下午5:26，Randy Dunlap写道： >>> On 12/5/23 22:52, Arnd Bergmann wrote: >>>> On Wed, Dec 6, 2023, at 06:24, Randy Dunlap wrote: > >>>> I think it's bad style to force-select an optional subsystem. >>>> How about making the entire file optional? It seems that there >>>> are already __weak functions in its place. >>> >>> Yes, I agree in general. >>> >>> Hopefully the maintainer will opine your suggestion. >>> Jiaxun? >> >> LGTM, PM is not an essential function here. >> Arnd, do you mind making it a patch? >> > > I just tried it out and my version doesn't actually work since > we still end up building the file with SERIO_I82042=m. > > We could still make it work by checking for serio being > built-in here, but in the end I think that's worse than > Randy's patch, so let's just go with his original version. > > Arnd I think that we should look for yet another alternative then. I don't believe that adding "select INPUT" is a good idea. It would be the only "select INPUT" in the entire kernel tree. thanks. -- #Randy https://people.kernel.org/tglx/notes-about-netiquette https://subspace.kernel.org/etiquette.html
