Hi Andy,
Le lundi 11 décembre 2023 à 20:57 +0200, Andy Shevchenko a écrit :
> For the better flexibility use C99 initializers in
> PINCTRL_PIN_GROUP().
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> drivers/pinctrl/pinctrl-ingenic.c | 21 +++++++++++++--------
> 1 file changed, 13 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-ingenic.c
> b/drivers/pinctrl/pinctrl-ingenic.c
> index ee718f6e2556..f5661dcdedf5 100644
> --- a/drivers/pinctrl/pinctrl-ingenic.c
> +++ b/drivers/pinctrl/pinctrl-ingenic.c
> @@ -82,16 +82,21 @@
> #define PINS_PER_GPIO_CHIP 32
> #define JZ4730_PINS_PER_PAIRED_REG 16
>
> -#define INGENIC_PIN_GROUP_FUNCS(name, id, funcs) \
> - { \
> - name, \
> - id##_pins, \
> - ARRAY_SIZE(id##_pins), \
> - funcs, \
> +#define INGENIC_PIN_GROUP_FUNCS(_name_, id,
> funcs) \
> + {
> \
> + .name =
> _name_, \
> + .pins =
> id##_pins, \
> + .num_pins =
> ARRAY_SIZE(id##_pins), \
> + .data =
> funcs, \
> }
>
> -#define INGENIC_PIN_GROUP(name, id, func) \
> - INGENIC_PIN_GROUP_FUNCS(name, id, (void *)(func))
> +#define INGENIC_PIN_GROUP(_name_, id,
> func) \
> + {
> \
> + .name =
> _name_, \
> + .pins =
> id##_pins, \
> + .num_pins =
> ARRAY_SIZE(id##_pins), \
> + .data = (void
> *)func, \
> + }
This INGENIC_PIN_GROUP() macro doesn't need to be modified, does it?
Cheers,
-Paul
>
> enum jz_version {
> ID_JZ4730,
