On Tue, Dec 12, 2023 at 10:55:33AM +0100, Ard Biesheuvel wrote: > On Fri, 10 Nov 2023 at 02:39, Daniel Walker <danielwa@xxxxxxxxx> wrote: > > > > This adds code to handle the generic command line changes. > > The efi code appears that it doesn't benefit as much from this design > > as it could. > > > > For example, if you had a prepend command line with "nokaslr" then > > you might be helpful to re-enable it in the boot loader or dts, > > but there appears to be no way to re-enable kaslr or some of the > > other options. > > > > The efi command line handling is incorrect. x86 and arm have an append > > system however the efi code prepends the command line. > > > > For example, you could have a non-upgradable bios which sends > > > > efi=disable_early_pci_dma > > > > This hypothetically could have been set because early pci dma caused > > issues on early versions of the product. > > > > Then later the early pci dma was made to work and the company desired > > to start using it. To override the bios you could set the CONFIG_CMDLINE > > to, > > > > efi=no_disable_early_pci_dma > > > > then parsing would normally start with the bios command line, then move > > to the CONFIG_CMDLINE and you would end up with early pci dma turned on. > > > > however, current efi code keeps early pci dma off because the bios > > arguments always override the built in. > > > > Per my reading this is different from the main body of x86, arm, and > > arm64. > > > > The generic command line provides both append and prepend, so it > > alleviates this issue if it's used. However not all architectures use > > it. > > > > It would be desirable to allow the efi stub to have it's builtin command > > line to be modified after compile, but I don't see a feasible way to do > > that currently. > > > > Cc: xe-linux-external@xxxxxxxxx > > Signed-off-by: Daniel Walker <danielwa@xxxxxxxxx> > > There are quite some 'might be's and 'hypothetical's in this commit log. > > Is there an actual use case that you are addressing here? Without > that, this looks like unnecessary churn to me, tbh. > > Note that this code executes in the context of platform firmware, > which may be old and buggy so we should be cautious about making > unnecessary changes here. It's been a while since I wrote this patch description, but there is an example I provided in the description. If you intend to enable early pci dma the command line parsing may still disable it because of how the parsing works inside the efi stub. There is an implementation difference between the efi stub and the architectures which results in this problem. This was not an issue I observed in the wild, it was the results of code review of the efi stub. Maybe the greater issue is that the efi stub seems to have connected itself to the kernels command line system. If the kernel changes then EFI stub must also change. Daniel
