Hi, > Am 05.12.2023 um 14:29 schrieb Maxime Ripard <mripard@xxxxxxxxxx>: > > Hi, > > On Tue, Dec 05, 2023 at 09:18:58AM +0100, H. Nikolaus Schaller wrote: >>> Am 05.12.2023 um 07:57 schrieb Maxime Ripard <mripard@xxxxxxxxxx>: >>> >>> On Mon, Dec 04, 2023 at 12:22:36PM -0600, Andrew Davis wrote: >>>> The Imagination PowerVR Series5 "SGX" GPU is part of several SoCs from >>>> multiple vendors. Describe how the SGX GPU is integrated in these SoC, >>>> including register space and interrupts. Clocks, reset, and power domain >>>> information is SoC specific. >>>> >>>> Signed-off-by: Andrew Davis <afd@xxxxxx> >>>> --- >>>> .../devicetree/bindings/gpu/img,powervr.yaml | 69 +++++++++++++++++-- >>>> 1 file changed, 63 insertions(+), 6 deletions(-) >>> >>> I think it would be best to have a separate file for this, img,sgx.yaml >>> maybe? >> >> Why? > > Because it's more convenient? Is it? >> The whole family of IMG GPUs is PowerVR and SGX and Rogue are generations 5 and 6++: >> >> https://en.wikipedia.org/wiki/PowerVR > > That's not really relevant as far as bindings go. But maybe for choosing binding file names. Well they are machine readable but sometimes humans work with them. > We have multiple > binding files for devices of the same generation, or single bindings > covering multiple generations. > > The important part is that every compatible is documented. It doesn't > really matter how or where. Yes, and that is why I would find it more convenient to have a single "img,powervr.yaml" for all variations unless it becomes filled with unrelated stuff (which isn't as far as I see). BR, Nikolaus
