On Thu, Nov 23, 2023 at 09:33:23AM +0100, Uwe Kleine-König wrote: > Error messages are supposed to end in \n. Add the line terminator to the > two error messages that lack this. > > Suggested-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > --- > Hello, > > this was noticed by Paul in > https://lore.kernel.org/linux-pwm/ba21c20b20364a39d5ffff81dac8bd300a746dbb.camel@xxxxxxxxxxxxxxx. > Instead of sneaking this into a patch that probably won't get applied > quickly, make this explicit. > > I based it on top of my PR that can be found at > https://lore.kernel.org/linux-pwm/20231121112029.gyv3gqirlycysyr4@xxxxxxxxxxxxxx, > but applies just fine to v6.7-rc1. > > If you want a fixes-line, that would be: > > Fixes: 485b56f08f33 ("pwm: jz4740: Improve algorithm of clock calculation") > > for the first hunk and > > Fixes: ce1f9cece057 ("pwm: jz4740: Use clocks from TCU driver") > > for the second. If this is backported to something before > v5.10-rc1~57^2~11, there is another instance with a missing \n. > > Best regards > Uwe My recollection is that the newlines aren't strictly required because printk will typically insert them itself (unless KERN_CONT is involved at some point). So I don't think this really fixes anything, but I'm willing to pick this up for consistency. Thierry
Attachment:
signature.asc
Description: PGP signature
