On Thu, Nov 23, 2023 at 12:10:57PM +0100, J. Neuschäfer wrote: > On Wed, Nov 22, 2023 at 06:35:32PM +0200, Andy Shevchenko wrote: > > The struct group_desc has a lot of duplication with struct pingroup. > > Deduplicate that by embeddind the latter in the former and convert > > users. > > It is strange to me that struct pingroup was introduced without any > reference to the pre-existing struct group_desc, but it's good to see > them unified at last. Yep! > Even better might be to move the definitions next to each other in the > same file, so that anyone who finds one, also finds the other. group_desc is a private to pin control generic implementation, pingroup is generic for any pin control driver. Their current split is a right thing to do, so no action required in this sense. Thank you for review! > > Linus, assuming everything is fine, I can push this to my tree. > > Or you can apply it (assumming all CIs and people are happy with > > the series). > > > > NB. This series contains previously sent patches for Qualcomm and > > Nuovoton. Here the updated version for Qualcomm that splits previous > > patch to two and fixes compilation warnings. > > > > NB. The function_desc is in plan to follow the similar deduplication. -- With Best Regards, Andy Shevchenko
