On Sat, Oct 07, 2023 at 01:45:23PM +0800, Keguang Zhang wrote: > On Fri, Sep 29, 2023 at 12:42 AM Conor Dooley <conor@xxxxxxxxxx> wrote: > > > > Hey, > > > > On Thu, Sep 28, 2023 at 08:19:52PM +0800, Keguang Zhang wrote: > > > Add devicetree binding document for Loongson-1 DMA. > > > > > > Signed-off-by: Keguang Zhang <keguang.zhang@xxxxxxxxx> > > > --- > > > V4 -> V5: > > > A newly added patch > > > > > > .../bindings/dma/loongson,ls1x-dma.yaml | 64 +++++++++++++++++++ > > > 1 file changed, 64 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/dma/loongson,ls1x-dma.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/dma/loongson,ls1x-dma.yaml b/Documentation/devicetree/bindings/dma/loongson,ls1x-dma.yaml > > > new file mode 100644 > > > index 000000000000..51b45d998a58 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/dma/loongson,ls1x-dma.yaml > > > @@ -0,0 +1,64 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/dma/loongson,ls1x-dma.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Loongson-1 DMA Controller > > > + > > > +maintainers: > > > + - Keguang Zhang <keguang.zhang@xxxxxxxxx> > > > + > > > +description: | > > > > This | isn't required as you have no formatting to preserve here. > > > Will remove '|'. > > > > + Loongson-1 DMA controller provides 3 independent channels for > > > + peripherals such as NAND and AC97. > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - loongson,ls1b-dma > > > + - loongson,ls1c-dma > > > > From a skim of the driver, these two devices seem to be compatible, > > and therefore one should fall back to the other. > > > Got it. How about changing to one const? > compatible: > const: loongson,ls1-dma No, keep the compatibles you have & set up a fallback please. Too many of these loongson bindings have got in with overly generic compatibles...
Attachment:
signature.asc
Description: PGP signature
