On Thu, Sep 21, 2023 at 07:04:24PM +0800, Baoquan He wrote: > By adding <asm-generic/io.h> support, the duplicated phys_to_virt > can be removed to use the default version in <asm-gneneric/io.h>. > > Meanwhile move isa_bus_to_virt() down below <asm-generic/io.h> including > to fix the compiling error of missing phys_to_virt definition. > > Signed-off-by: Baoquan He <bhe@xxxxxxxxxx> > Cc: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> > Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > Cc: Helge Deller <deller@xxxxxx> > Cc: Serge Semin <fancer.lancer@xxxxxxxxx> > Cc: Florian Fainelli <f.fainelli@xxxxxxxxx> > Cc: Huacai Chen <chenhuacai@xxxxxxxxxx> > Cc: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx> > Cc: linux-mips@xxxxxxxxxxxxxxx > --- > arch/mips/include/asm/io.h | 28 +++++----------------------- > 1 file changed, 5 insertions(+), 23 deletions(-) Acked-by: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]