On Fri, Sep 29, 2023 at 05:43:41PM +0300, Dan Carpenter wrote:
> On Fri, Sep 29, 2023 at 05:39:46PM +0300, Dan Carpenter wrote:
> > On Fri, Sep 29, 2023 at 05:18:31PM +0300, Dan Carpenter wrote:
> > > This is weird.
> > >
> > > I managed to reproduce this once but couldn't reproduce it again after
> > > that. It seems like an intermittent thing to me.
> >
> > Nope. I'm just dumb.
> >
> > Commit b33a296d8311 ("staging: octeon: remove typedef in structs
> > cvmx_pip_port_status_t and cvmx_pko_port_status_t") updated
> > drivers/staging/octeon/octeon-stubs.h but didn't update
> > arch/mips/include/asm/octeon/cvmx-pip.h.
> >
> > I can send a patch for that.
>
> Actually, perhaps we should just revert the patch? Staging patches
> aren't supposed to touch outside of the staging directory.
I think all of these break the build...
b33a296d8311 staging: octeon: remove typedef in structs cvmx_pip_port_status_t and cvmx_pko_port_status_t
4fffe4733cfb staging: octeon: remove typedef in enum cvmx_pko_status_t
8d26aa90458f staging: octeon: remove typedef in struct cvmx_pko_lock_t
28fae776c69b staging: octeon: remove typedef in enum cvmx_pow_wait_t
a13f7e45823c staging: octeon: remove typedef in enum cvmx_helper_interface_mode_t
7bebd8321776 staging: octeon: remove typedef in enum cvmx_spi_mode_t
regards,
dan carpenter
