On Sat, Aug 19, 2023 at 10:23 PM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 16/08/2023 13:13, Keguang Zhang wrote: > > Add Loongson LS1B and LS1C compatibles for system controller. > > I asked not to use the same compatible for different blocks. Compatible > is dwmac, but are you still going to use for other blocks? Please write > proper description of the hardware. > Sorry. I didn't make myself clear. The SoC only has one syscon with two registers. And Each register contains settings for multiple devices. Besides DWMAC, this syscon will be used for other devices. Should I keep using loongson,ls1b-syscon/loongson,ls1c-syscon? > > > > Signed-off-by: Keguang Zhang <keguang.zhang@xxxxxxxxx> > > --- > > V1 -> V2: Make the syscon compatibles more specific > > > > Documentation/devicetree/bindings/mfd/syscon.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml > > index 8103154bbb52..d701fff02abe 100644 > > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml > > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml > > @@ -49,6 +49,8 @@ properties: > > - hisilicon,peri-subctrl > > - hpe,gxp-sysreg > > - intel,lgm-syscon > > + - loongson,ls1b-dwmac-syscon > > + - loongson,ls1c-dwmac-syscon > > > Best regards, > Krzysztof > -- Best regards, Keguang Zhang
