On Tue, Aug 8, 2023 at 3:46 PM Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Tue, Aug 8, 2023, at 15:12, Linus Walleij wrote: > > Normally you would do this so as to override the default virt_to_phys() > > from include/asm-generic/io.h, but we do not seem to be using it here? > > Correct. In linux-next, we have converted arch/sh to use > include/asm-generic/io.h, so arch/mips is now the last one > to not use it. > > I see that Jiaxun Yang posted a patch for this in May and it looked > like it should finally work [1], but there seems to still be something > missing. Oh that's a nice patch! > For the moment, I'd suggest we leave the #define in place > here in order to finish the patch that starts using the > asm-generic header, and then we can look into using more > of the generic code. Sure, no point in causing stir with Jiaxun's work, let's drop this patch. Yours, Linus Walleij
