On Mon, Jul 24, 2023 at 3:31 AM Shiji Yang <yangshiji66@xxxxxxxxxxx> wrote: > We use pinctrl_select_state() to request the pinctrl and set the pin > function. After searching "include/linux/pinctrl/consumer.h", I don't > find a relevant API to reverse this operation so we can't set .enabled > back to the false state. If I'm wrong please correct me, I don't know > much about the pinctrl architecture. I don't think that has much to do with the pinctrl core. I expect the driver to set this .enabled variable to false wherever the enablement fails, note that this is inside struct mtmips_priv *p, i.e. nothing to do with the pin control core. This patch appears to paper over the real issue. Yours, Linus Walleij
