On Wed, Jul 26, 2023 at 6:08 PM bibo mao <maobibo@xxxxxxxxxxx> wrote: > > > > 在 2023/7/26 17:53, Marc Zyngier 写道: > > On Wed, 26 Jul 2023 10:45:51 +0100, > > bibo mao <maobibo@xxxxxxxxxxx> wrote: > >> > >> slight ping :) > > > > Given that you have sent this series 5 times in two weeks, I don't > > think anyone is in a hurry to review it again. Just give it time. > Ok, I see. > Sorry to bring out some noise and thanks for your response. 1, If we really need a "virtual eiointc" variant, please document it in Documentation/loongarch/irq-chip-model.rst and Documentation/translations/zh_CN/loongarch/irq-chip-model.rst. 2, Then, I think it is better to only modify the type of 'index' in Patch-1, and move the 'if (index < 0) ...' modifications to Patch-2. Because all "virtual eiointc" code should be in a single patch. Huacai > > Regards > Bibo Mao > > > > Thanks, > > > > M. > > > >> > >> 在 2023/7/19 14:35, Bibo Mao 写道: > >>> Fix return value checking of eiointc_index where int type > >>> is converted uint32_t and check smaller than 0. > >>> > >>> Add simple irq route support on system with only one eiointc node, > >>> rather than use anysend method. > >>> > >>> --- > >>> Changes in v5: > >>> Modify typo issue. > >>> > >>> Changes in v4: > >>> Modify some spell checking problems. > >>> Add Fixes tag. > >>> > >>> Changes in v3: > >>> Modify some spell checking problems. > >>> > >>> Changes in v2: > >>> Use the simple irq routing on embeded board like 2K0500 and 2K2000 > >>> board, since there is only one eio node. > >>> > >>> --- > >>> Bibo Mao (2): > >>> irqchip/loongson-eiointc: Fix return value checking of eiointc_index > >>> irqchip/loongson-eiointc: Simplify irq routing on some platforms > >>> > >>> drivers/irqchip/irq-loongson-eiointc.c | 93 +++++++++++++++++++++++--- > >>> 1 file changed, 82 insertions(+), 11 deletions(-) > >>> > >> > >> > > >
