On 29.07.2023 14:45, Rafał Miłecki wrote:
Hi,
I'm trying to understand MediaTek's Ethernet controller resets.
I noticed there is sth fishy when checking dts files. See following
errors:
arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb:
ethernet@1e100000: resets: [[2, 6], [2, 23]] is too short
From schema:
Documentation/devicetree/bindings/net/mediatek,net.yaml
arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb:
ethernet@1e100000: reset-names:1: 'gmac' was expected
From schema:
Documentation/devicetree/bindings/net/mediatek,net.yaml
arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb:
ethernet@1e100000: reset-names: ['fe', 'eth'] is too short
From schema:
Documentation/devicetree/bindings/net/mediatek,net.yaml
arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb:
ethernet@1e100000: Unevaluated properties are not allowed
('reset-names', 'resets' were unexpected)
From schema:
Documentation/devicetree/bindings/net/mediatek,net.yaml
Sigh, looks like this patch was applied regardless of my points here.
Now we're here picking up the pieces.
https://lore.kernel.org/netdev/b6c7462d-99fc-a8e1-1cc2-d0a1efc7c34d@xxxxxxxxxx/
1. Binding mediatek,net.yaml
It says that when present, there must be 3 resets: fe, gmac, ppe
2. mt7621.dtsi
It specifies 2 resets: fe, eth
3. mt7622.dtsi
It doesn't specify any resets
4. mt7629.dtsi
It doesn't specify any resets
5. drivers/net/ethernet/mediatek/
I don't see any reset_control_* code at all
Can someone help me what's the actual case with resets? Are they needed?
Are they used?
I'm adding Sergio to CC as they've been the one working on this on
mt7621.dtsi.
There's relevant information here.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=64b2d6ffff862c0e7278198b4229e42e1abb3bb1
Arınç
