Hi Huacai, > > Secondly: > > > > cflags-$(CONFIG_CC_IS_GCC) += -march=loongson3a > > cflags-$(CONFIG_CC_IS_CLANG) += -march=mips64r2 > > > > document compiler peculiarities. Does Clang support, or intend to, > > `-march=loongson3a'? If so, what version can we expect this stuff in? > > GCC has had it since 4.6 or Y2010, which is pretty long ago. > GCC support loongson3a/mips64r2, Clang only support mips64r2. If we use > $(call cc-option,-march=loongson3a,-march=mips64r2) > both GCC and Clang can work and we don't need to care about the compiler. This may well be a change we desire, but it has to be made and reviewed on its own rather than being buried within a set of unrelated changes. Then the rationale has to be given in the change description and a comment put in code explaining that it's not the usual case of old/new compiler, so that we can catch it later and remove should Clang developers decide to include `-march=loongson3a' support and our version requirements catch up. Maciej
