On Thu, 20 Jul 2023 10:01:10 +0200 Christoph Hellwig <hch@xxxxxx> wrote: > On Thu, Jul 20, 2023 at 09:56:09AM +0200, Petr Tesařík wrote: > > On Thu, 20 Jul 2023 08:38:19 +0200 > > Christoph Hellwig <hch@xxxxxx> wrote: > > > > > On Thu, Jul 13, 2023 at 05:23:13PM +0200, Petr Tesarik wrote: > > > > From: Petr Tesarik <petr.tesarik.ext@xxxxxxxxxx> > > > > > > > > Add some kernel-doc comments and move the existing documentation of struct > > > > io_tlb_slot to its correct location. The latter was forgotten in commit > > > > 942a8186eb445 ("swiotlb: move struct io_tlb_slot to swiotlb.c"). > > > > > > > > Use the opportunity to give swiotlb_do_find_slots() a more descriptive > > > > name, which makes it clear how it differs from swiotlb_find_slots(). > > > > > > Please keep the swiotlb_ prefix. Otherwise this looks good to me. > > > > Will do. Out of curiosity, why does it matter for a static (file-local) > > function? > > Because it makes looking at stack traces much easier. Got it. Thanks! Petr T