On Wed, Jul 19, 2023 at 3:30 PM Keguang Zhang <keguang.zhang@xxxxxxxxx> wrote: > > On Wed, Jul 19, 2023 at 6:14 PM Andrei Coardos <aboutphysycs@xxxxxxxxx> wrote: > > > > In the drivers/gpio/gpio-loongson1 the call to platform_set_drvdata was > > removed. > > This function call was found to be unnecesarry as the associated unnecessary > > structure is defined inside the local .c file. > > It doesn't use any type of function either so it can be removed without > > any complications. > > If there is a ls1x_gpio_remove(), platform_get_drvdata() will be called. > Then platform_set_drvdata() will be necessary. I don't get this. Is it just a side note? To me the patch looks legit. ... With typo fixed, Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> -- With Best Regards, Andy Shevchenko
