Sometimes when driver fails to probe a device, the kernel will retry
it later. However, this will result in duplicate requests for the
same pinctrl configuration. In this case, we should not throw error
logs. This patch adds extra check for the pin group function. Now the
pinctrl driver only prints error log when attempting to configure the
same group as different functions.
Signed-off-by: Shiji Yang <yangshiji66@xxxxxxxxxxx>
---
drivers/pinctrl/mediatek/pinctrl-mtmips.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtmips.c b/drivers/pinctrl/mediatek/pinctrl-mtmips.c
index efd77b6c5..8f5493220 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtmips.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtmips.c
@@ -125,8 +125,9 @@ static int mtmips_pmx_group_enable(struct pinctrl_dev *pctrldev,
/* dont allow double use */
if (p->groups[group].enabled) {
- dev_err(p->dev, "%s is already enabled\n",
- p->groups[group].name);
+ if (!p->func[func]->enabled)
+ dev_err(p->dev, "%s is already enabled\n",
+ p->groups[group].name);
return 0;
}
--
2.30.2
