On Tue, 11 Jul 2023 13:08:06 +0100,
Bibo Mao <maobibo@xxxxxxxxxxx> wrote:
>
> Return value of function eiointc_index is int, however it is converted
> into uint32_t and then compared smaller than zero. This causes logic
> problem. There is eioint initialization problem on qemu virt-machine
> where there is only one eioint node and more than 4 vcpus. Nodemap of
> eioint is 1, and external device intr can only be routed to vcpu 0-3, the
> other vcpus can not response any external device interrupts and only local
> processor interrupts like ipi/timer can work.
>
> Signed-off-by: Bibo Mao <maobibo@xxxxxxxxxxx>
> ---
> drivers/irqchip/irq-loongson-eiointc.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/irqchip/irq-loongson-eiointc.c b/drivers/irqchip/irq-loongson-eiointc.c
> index 92d8aa28bdf5..1c5a5b59f199 100644
> --- a/drivers/irqchip/irq-loongson-eiointc.c
> +++ b/drivers/irqchip/irq-loongson-eiointc.c
> @@ -144,12 +144,14 @@ static int eiointc_router_init(unsigned int cpu)
> int i, bit;
> uint32_t data;
> uint32_t node = cpu_to_eio_node(cpu);
> - uint32_t index = eiointc_index(node);
> + int index = eiointc_index(node);
>
> - if (index < 0) {
> - pr_err("Error: invalid nodemap!\n");
> - return -1;
> - }
> + /*
> + * qemu virt-machine has only one eio intc and more than four cpus
> + * irq from eio can only be routed to cpu 0-3 on virt machine
> + */
> + if (index < 0)
> + return 0;
>
> if ((cpu_logical_map(cpu) % CORES_PER_EIO_NODE) == 0) {
> eiointc_enable();
This sort of thing really needs a Fixes: tag.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
