Re: [PATCH] MIPS: Loongson: Fix cpu_probe_loongson() again

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 26, 2023 at 03:50:14PM +0800, Huacai Chen wrote:
> Commit 7db5e9e9e5e6c10d7d ("MIPS: loongson64: fix FTLB configuration")
> move decode_configs() from the beginning of cpu_probe_loongson() to the
> end in order to fix FTLB configuration. However, it breaks the CPUCFG
> decoding because decode_configs() use "c->options = xxxx" rather than
> "c->options |= xxxx", all information get from CPUCFG by decode_cpucfg()
> is lost.
> 
> This causes error when creating a KVM guest on Loongson-3A4000:
> Exception Code: 4 not handled @ PC: 0000000087ad5981, inst: 0xcb7a1898 BadVaddr: 0x0 Status: 0x0
> 
> Fix this by moving the c->cputype setting to the beginning and moving
> decode_configs() after that.
> 
> Fixes: 7db5e9e9e5e6c10d7d ("MIPS: loongson64: fix FTLB configuration")
> Cc: stable@xxxxxxxxxxxxxxx
> Cc: Huang Pei <huangpei@xxxxxxxxxxx>
> Signed-off-by: Huacai Chen <chenhuacai@xxxxxxxxxxx>
> ---
>  arch/mips/kernel/cpu-probe.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]



[Index of Archives]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux