Hi, On Sat, Jun 24, 2023, Ladislav Michl wrote: > Hi, > > On Fri, Jun 23, 2023 at 11:24:24PM +0000, Thinh Nguyen wrote: > > On Fri, Jun 23, 2023, Ladislav Michl wrote: > > > Hi, > > > > > > On Thu, Jun 22, 2023 at 11:01:54PM +0000, Thinh Nguyen wrote: > > > > Hi, > > > [snip] > > > > Please use get_maintainer.pl to get all the proper maintainers to review > > > > the changes. > > > > > > That's what I did. Thomas, MIPS maintainer is reading linux-mips list, > > > Greg is reading linux-usb list, you were the one who receives changes, > > > hence all patcheset was sent to you in a hope you provide some comments > > > about actual code changes. > > > > I can take a look at the changes. However, the patches were sent > > directly To: me for patches related MIPS and no one else except the > > linux-usb linux-mips (without Thomas), which doesn't look right. > > > > I'm not familiar with the MIPS subsystem, but typically for the USB > > mailing list, we capture all the emails generated from get_maintainer.pl > > and include them To: and Cc: should they need attention to the changes. > > Often we filter our emails based on whether it's directed toward us, at > > least I do that. Also, we can't be sure if everyone still subscribes to > > the corresponding mailing list. > > Did you run get_maintainer.pl yourself? Because here (for v6.3) I get: > $ ./scripts/get_maintainer.pl -f arch/mips/cavium-octeon/octeon-usb.c > Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> (maintainer:MIPS,commit_signer:1/1=100%) > Ladislav Michl <ladis@xxxxxxxxxxxxxx> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:20/20=100%,removed_lines:22/22=100%) > linux-mips@xxxxxxxxxxxxxxx (open list:MIPS) > linux-kernel@xxxxxxxxxxxxxxx (open list) > $ ./scripts/get_maintainer.pl -f drivers/usb/dwc3 > Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx> (maintainer:DESIGNWARE USB3 DRD IP DRIVER) > Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> (supporter:USB SUBSYSTEM) > linux-usb@xxxxxxxxxxxxxxx (open list:DESIGNWARE USB3 DRD IP DRIVER) > linux-kernel@xxxxxxxxxxxxxxx (open list) > > So I have no clue who else should I add to Cc list... For each patch, please include all the emails returned from get_maintainer.pl including Greg's and Thomas's. > > > > > > > > Since this is a large change involving different subsystems, if > > > > possible, please split the changes related to MIPS and try to upstream > > > > those first as they will affect how dwc3 glue driver will look. > > > > > > That's pretty straightforward as patchset is arranged exactly this way, > > > so MIPS maintainer is free to apply patches till driver move. > > > However, any actual feedback would be still usefull. In case it gets > > > some acks I'll add them and rebase patches to the latest -next. > > > > > > > Then that's good. If the MIPS maintainer approves all the MIPS related > > changes and already pick them up, there should be no problem. > > Well, remaining question is how to make it comfortable for you to take > changes. Patches 1-7 are in mips-next already, so I propose to wait until > they propagate upstream then I rebase remaining patches to whatever is > in linux-next. Yes. Please rebase the remaining patches and resend them. > > Please note I added glue driver into Makefile and Kconfig at random > locations as I failed to find any logic here. If you have any preference > or want to sort those files alphabetically first for example, just let > me know and I'll add some cleanup patches before sending v2. Unfortunately there isn't really an order to them. What you did is fine. > > Also coleagues of mine meanwhile found that PLL indeed ocassionally > fails to lock, so workaround attached to cover letter is really needed. > Naturally it cannot sneak in as it is, so unless you have better idea > I'll just port it to recent driver state and we can start discussion > from there in a separate thread. If this causes a regression, then please fix it before sending it in. If it's a new found issue, you can create a fix patch at a later point. Thanks, Thinh
