Re: [PATCH] mips: ralink: introduce commonly used remap node function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 20, 2023 at 1:46 PM Shiji Yang <yangshiji66@xxxxxxxxxxx> wrote:
>
> The ralink_of_remap() function is repeated several times on SoC specific
> source files. They have the same structure, but just differ in compatible
> strings. In order to make commonly use of these codes, this patch
> introduces a newly designed mtmips_of_remap_node() function to match and
> remap all supported system controller and memory controller nodes.
>
> Build and run tested on MT7620 and MT7628.
>
> Signed-off-by: Shiji Yang <yangshiji66@xxxxxxxxxxx>
> ---
>  arch/mips/ralink/common.h |  2 --
>  arch/mips/ralink/mt7620.c |  9 ---------
>  arch/mips/ralink/mt7621.c |  9 ---------
>  arch/mips/ralink/of.c     | 42 ++++++++++++++++++++++++++++++++-------
>  arch/mips/ralink/rt288x.c |  9 ---------
>  arch/mips/ralink/rt305x.c |  9 ---------
>  arch/mips/ralink/rt3883.c |  9 ---------
>  7 files changed, 35 insertions(+), 54 deletions(-)

Awesome! More deletions than additions in arch folders is always a
good thing :-).

Changes look good to me. Thanks for doing this!

Reviewed-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>

Best regards,
    Sergio Paracuellos




[Index of Archives]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux