On Sat, Jun 3, 2023 at 2:05 AM Conor Dooley <conor@xxxxxxxxxx> wrote: > > On Fri, Jun 02, 2023 at 05:50:20PM +0800, Binbin Zhou wrote: > > Move Loongson RTC bindings from trivial-rtc.yaml into loongson,rtc.yaml. > > $subject: dt-bindings: rtc: Remove the LS2X from the trivial RTCs > > If you end up resubmitting, could you use a subject like that better > describes the changes? > Say "dt-bindings: rtc: Split loongson,ls2x-rtc into SoC-based compatibles"? OK, I got it. Thanks. Binbin > Otherwise, > Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > Thanks, > Conor. > > > > The architectures associated with this driver use the built-in DTB, so > > we can just drop the compatible(rtc-ls2x) with wildcards. > > Also, soc-based compatible is more accurate for hardware differences > > between chips. > > > > Signed-off-by: Binbin Zhou <zhoubinbin@xxxxxxxxxxx> > > --- > > .../devicetree/bindings/rtc/loongson,rtc.yaml | 57 +++++++++++++++++++ > > .../devicetree/bindings/rtc/trivial-rtc.yaml | 2 - > > 2 files changed, 57 insertions(+), 2 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/rtc/loongson,rtc.yaml > > > > diff --git a/Documentation/devicetree/bindings/rtc/loongson,rtc.yaml b/Documentation/devicetree/bindings/rtc/loongson,rtc.yaml > > new file mode 100644 > > index 000000000000..f89c1f660aee > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/rtc/loongson,rtc.yaml > > @@ -0,0 +1,57 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/rtc/loongson,rtc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Loongson Real-Time Clock > > + > > +description: > > + The Loongson family chips use an on-chip counter 0 (Time Of Year > > + counter) as the RTC. > > + > > +maintainers: > > + - Binbin Zhou <zhoubinbin@xxxxxxxxxxx> > > + > > +allOf: > > + - $ref: rtc.yaml# > > + > > +properties: > > + compatible: > > + oneOf: > > + - enum: > > + - loongson,ls1b-rtc > > + - loongson,ls1c-rtc > > + - loongson,ls7a-rtc > > + - loongson,ls2k1000-rtc > > + - items: > > + - enum: > > + - loongson,ls2k2000-rtc > > + - loongson,ls2k0500-rtc > > + - const: loongson,ls7a-rtc > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/interrupt-controller/irq.h> > > + > > + rtc@1fe27800 { > > + compatible = "loongson,ls2k1000-rtc"; > > + reg = <0x1fe27800 0x100>; > > + > > + interrupt-parent = <&liointc1>; > > + interrupts = <8 IRQ_TYPE_LEVEL_HIGH>; > > + }; > > + > > +... > > diff --git a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml > > index a3603e638c37..9af77f21bb7f 100644 > > --- a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml > > +++ b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml > > @@ -47,8 +47,6 @@ properties: > > - isil,isl1218 > > # Intersil ISL12022 Real-time Clock > > - isil,isl12022 > > - # Loongson-2K Socs/LS7A bridge Real-time Clock > > - - loongson,ls2x-rtc > > # Real Time Clock Module with I2C-Bus > > - microcrystal,rv3029 > > # Real Time Clock > > -- > > 2.39.1 > >
