The second element of array "struct resource res []" in arch/mips/txx9/generic/setup.c: 714-716 will run
only if the conditions "#if IS_ENABLED(CONFIG_TXX9_DMAC)"(line 707) and "#ifndef CONFIG_MACH_TX49XX" (line 713) both are true.
707 #if IS_ENABLED(CONFIG_TXX9_DMAC)
708 struct resource res[] = {
709 {
710 .start = baseaddr,
711 .end = baseaddr + 0x800 - 1,
712 .flags = IORESOURCE_MEM,
713 #ifndef CONFIG_MACH_TX49XX
714 }, {
715 .start = irq,
716 .flags = IORESOURCE_IRQ,
717 #endif
718 }
719 };
But according to the definition of the configuration option CONFIG_TXX9_DMAC (drivers/dma/Kconfig:614):
config TXX9_DMAC
tristate "Toshiba TXx9 SoC DMA support"
depends on MACH_TX49XX
select DMA_ENGINE
help
Support the TXx9 SoC internal DMA controller. This can be
integrated in chips such as the Toshiba TX4927/38/39.
"CONFIG_TXX9_DMAC" depends on "CONFIG_MACH_TX49XX". "CONFIG_TXX9_DMAC" will only be enabled
if "CONFIG_MACH_TX49XX" is enabled. So the lines 714-716 in arch/mips/txx9/generic/setup.c is a dead code.
I am not sure whether directly delete this dead code or
modify the dependency of the configuration option.
May I ask how to modify it?
Best Regards
Yanjie Ren
Ying Sun
