Re: [PATCH v4 5/7] pinctrl: ingenic: relax return value check for IRQ get

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Matti,

Le mardi 16 mai 2023 à 10:13 +0300, Matti Vaittinen a écrit :
> fwnode_irq_get[_byname]() were changed to not return 0 anymore.
> 
> Drop check for return value 0.
> 
> Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>

Reviewed-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>

Cheers,
-Paul

> 
> ---
> 
> The first patch of the series changes the fwnode_irq_get() so this
> depends
> on the first patch of the series and should not be applied alone.
> ---
>  drivers/pinctrl/pinctrl-ingenic.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-ingenic.c
> b/drivers/pinctrl/pinctrl-ingenic.c
> index 2f220a47b749..86e71ad703a5 100644
> --- a/drivers/pinctrl/pinctrl-ingenic.c
> +++ b/drivers/pinctrl/pinctrl-ingenic.c
> @@ -4201,8 +4201,6 @@ static int __init ingenic_gpio_probe(struct
> ingenic_pinctrl *jzpc,
>         err = fwnode_irq_get(fwnode, 0);
>         if (err < 0)
>                 return err;
> -       if (!err)
> -               return -EINVAL;
>         jzgc->irq = err;
>  
>         girq = &jzgc->gc.irq;
> -- 
> 2.40.1
> 
> 





[Index of Archives]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux