On Tue, Apr 18, 2023 at 6:13 AM Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> wrote: > > On Fri, Apr 14, 2023 at 09:06:56AM +0100, Jiaxun Yang wrote: > > microMIPS smartMIPS kernel can only be compiled if they are supported > > by toolchain. > > > > Signed-off-by: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx> > > Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> Question: won't the lack of this (patch and rest of the series) hurt our ability to test randconfig builds of ARCH=mips with clang? See also the 0day report from Boris: https://lore.kernel.org/llvm/202304170748.Fg9VIgGd-lkp@xxxxxxxxx/ i.e. randconfig will continue to select options that can't be built yet. > > --- > > arch/mips/Kconfig | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > > index 41ac4dc5aae4..0b270562c3eb 100644 > > --- a/arch/mips/Kconfig > > +++ b/arch/mips/Kconfig > > @@ -2360,7 +2360,7 @@ config CPU_NEEDS_NO_SMARTMIPS_OR_MICROMIPS > > Select this if you want neither microMIPS nor SmartMIPS support > > > > config CPU_HAS_SMARTMIPS > > - depends on SYS_SUPPORTS_SMARTMIPS > > + depends on SYS_SUPPORTS_SMARTMIPS && CC_HAS_SMARTMIPS > > bool "SmartMIPS" > > help > > SmartMIPS is a extension of the MIPS32 architecture aimed at > > @@ -2373,6 +2373,7 @@ config CPU_HAS_SMARTMIPS > > > > config CPU_MICROMIPS > > depends on 32BIT && SYS_SUPPORTS_MICROMIPS && !CPU_MIPSR6 > > + depends on CC_HAS_MICROMIPS > > bool "microMIPS" > > help > > When this option is enabled the kernel will be built using the > > hmm, with this change the options will silently be dropped. I prefer > the error message, that the compiler doesn't support what is configured. > > Thomas. > > -- > Crap can work. Given enough thrust pigs will fly, but it's not necessarily a > good idea. [ RFC1925, 2.3 ] -- Thanks, ~Nick Desaulniers
