Re: [PATCH v2 6/7] MIPS: Fallback CPU -march CFLAG to ISA level if unsupported

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> 2023年4月18日 21:07,Nick Desaulniers <ndesaulniers@xxxxxxxxxx> 写道:
> 
> On Fri, Apr 14, 2023 at 1:07 AM Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx> wrote:
>> 
>> LLVM does not implement some of -march options. However those options
>> are not mandatory for kernel to build for those CPUs.
>> 
>> Fallback -march CFLAG to ISA level if unsupported by toolchain so
>> we can get those kernel to build with LLVM.
>> 
>> Link: https://github.com/ClangBuiltLinux/linux/issues/1544
>> Reported-by: Nathan Chancellor <nathan@xxxxxxxxxx>
>> Signed-off-by: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>
> 
> Thanks for the patch! Maybe it's more obvious to folks who work on
> mips, but how did you determine that say `p5600` is `mips32r5` or
> `r10000` is `mips4`?

Wikipedia [1] should fit the purpose.

> 
> Is there a table somewhere you used as a reference? Including such
> info in the commit message would help reviewers such as myself verify
> the patch.
> 
> Also, in v1, you mentioned that -mtune is not a substitute. It would
> be good to record that info in the commit message as well.

Thanks for the input! Will reword in next rev.

> 


[1]: https://en.wikipedia.org/wiki/List_of_MIPS_architecture_processors

Thanks
- Jiaxun



[Index of Archives]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux