> I'm proposing to leave all that trickery behind and just follow what's > written in device tree, so each I/O interface ends up as a driver > with its own mac ops. While it is possible to implement that as > private mac ops as some other drivers do, I think it is more > convenient to use phylink_mac_ops. > > In case I'm missing something or I'm wrong with analysis, please let > me know. It is a reasonable solution, and does help clean up some of the mess keeping it in staging. But as Maintainers, we also have to consider, are you just going to add the cleanup you need in order that phylink supports SFPs, which is what you seem most interesting in. And then stop the cleanup. Despite the code being in staging, it is good enough for you. So converting to phylink, with the existing feature set, is fine. Maybe adding SFP support is a new feature, and we might consider not accepting such patches until the driver has made it out of staging? Andrew
