On Thu, Mar 30, 2023 at 7:33 PM Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> wrote: > > On Thu, Mar 30, 2023 at 06:20:12PM +0800, Keguang Zhang wrote: > > The Loongson-1 restart handler will be moved to watchdog driver, > > then _machine_restart is no longer needed. > > The _machine_halt and pm_power_off are also unnecessary, > > which contain no hardware operations. > > > > Therefore, remove the entire reset.c and related header file. > > Update the Makefile accordingly. > > > > Signed-off-by: Keguang Zhang <keguang.zhang@xxxxxxxxx> > > --- > > .../include/asm/mach-loongson32/regs-wdt.h | 15 ------ > > arch/mips/loongson32/common/Makefile | 2 +- > > arch/mips/loongson32/common/reset.c | 51 ------------------- > > 3 files changed, 1 insertion(+), 67 deletions(-) > > delete mode 100644 arch/mips/include/asm/mach-loongson32/regs-wdt.h > > delete mode 100644 arch/mips/loongson32/common/reset.c > > Acked-by: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> > Thomas, Sorry! I forgot to remove the reference to regs-wdt.h, which will cause a build error. Could you please review v2: https://lore.kernel.org/all/20230330112051.551648-2-keguang.zhang@xxxxxxxxx/ Thanks very much! > -- > Crap can work. Given enough thrust pigs will fly, but it's not necessarily a > good idea. [ RFC1925, 2.3 ] -- Best regards, Keguang Zhang
