Re: [PATCH] Mips: Fix _CONST64_(x) as unsigned

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> 2023年4月11日 07:31,Qing Zhang <zhangqing@xxxxxxxxxxx> 写道:
> 
> Addresses should all be of unsigned type to avoid unnecessary conversions.

It’s defined as signed for a reason. To keep consistent with 32-bit address, which
Is sign-extended on 64bit systems.

Thanks
Jiaxun

> 
> Signed-off-by: Qing Zhang <zhangqing@xxxxxxxxxxx>
> ---
> arch/mips/include/asm/addrspace.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/mips/include/asm/addrspace.h b/arch/mips/include/asm/addrspace.h
> index 59a48c60a065..75d36115a25e 100644
> --- a/arch/mips/include/asm/addrspace.h
> +++ b/arch/mips/include/asm/addrspace.h
> @@ -25,9 +25,9 @@
> #define _ATYPE32_ int
> #define _ATYPE64_ __s64
> #ifdef CONFIG_64BIT
> -#define _CONST64_(x) x ## L
> +#define _CONST64_(x) x ## UL
> #else
> -#define _CONST64_(x) x ## LL
> +#define _CONST64_(x) x ## ULL
> #endif
> #endif
> 
> -- 
> 2.20.1
> 





[Index of Archives]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux