> -void cvm_oct_rx_initialize(void)
> +int cvm_oct_rx_initialize(void)
> {
> int i;
> struct net_device *dev_for_napi = NULL;
> @@ -460,8 +460,11 @@ void cvm_oct_rx_initialize(void)
> }
> }
>
> - if (!dev_for_napi)
> - panic("No net_devices were allocated.");
> + if (!dev_for_napi) {
> + pr_err("No net_devices were allocated.");
It is good practice to use dev_per(dev, ... You then know which device
has problem finding its net_devices.
checkpatch is probably warning you about this.
Once you have a registered netdev, you should then use netdev_err(),
netdev_dbg() etc.
However, cvm_oct_probe() in 6.3-rc6 seems to be FUBAR. As soon as you
call register_netdev(dev), the kernel can start using it, even before
that call returns. So the register_netdev(dev) should be the last
thing _probe does, once everything is set up. You can call
netdev_err() before it is registered, but the name is less
informative, something like "(unregistered)".
Andrew
