On Wed, Apr 12, 2023 at 03:42:21PM +0100, Jiaxun Yang wrote: > > > > 2023年4月12日 14:31，Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> 写道： > > > > On Sat, Apr 08, 2023 at 12:59:36PM +0100, Jiaxun Yang wrote: > >> Set default CPU model to Release 2 CPUs (MIPS64R2 if 64 bit CPU > >> is present, otherwise MIPS32R2) to get better feature coverage > >> on various default configs. > >> > >> Also set default kernel code model to 64 bit since nowadays it > >> doesn't make much sense to run 32 bit kernel on a 64 bit system. > >> > >> Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx> > >> Signed-off-by: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx> > >> --- > >> arch/mips/Kconfig | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > >> index ecc7a755fae6..1d681dd87bb0 100644 > >> --- a/arch/mips/Kconfig > >> +++ b/arch/mips/Kconfig > >> @@ -1260,6 +1260,8 @@ menu "CPU selection" > >> > >> choice > >> prompt "CPU type" > >> + default CPU_MIPS64_R2 if SYS_HAS_CPU_MIPS64_R2 > >> + default CPU_MIPS32_R2 if SYS_HAS_CPU_MIPS32_R2 > >> default CPU_R4X00 > > > > I don't think this makes things better. For systems with multiple > > possible CPU choices it's quite easy to get a kernel compiled for > > the wrong ISA. > > Well this is only for best allmodconfig coverage. > > Or at least: > default CPU_MIPS32_R2 if MIPS_GENERIC_KERNEL > > Can make things better. not if there is the option SYS_HAS_CPU_R4X00 for MIPS_GENERIC_KERNEL selected. I've reverted the commit doing this, but still this is IMHO the wrong way forward. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
