Re: [PATCH v3] mtd: nand: Convert to platform remove callback returning void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2023-04-11 at 11:38:16 UTC, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Acked-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>
> Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx> # atmel
> Reviewed-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx> # ingenic
> Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> # ingenic
> Acked-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> # intel
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> # meson
> Acked-by: Roger Quadros <rogerq@xxxxxxxxxx> # omap_elm
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> # renesas
> Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx> # rockchip
> Acked-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx> # sunxi
> Acked-by: Thierry Reding <treding@xxxxxxxxxx> # tegra
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel



[Index of Archives]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux