Le samedi 01 avril 2023 à 18:19 +0200, Uwe Kleine-König a écrit :
> The .remove() callback for a platform driver returns an int which
> makes
> many driver authors wrongly assume it's possible to do error handling
> by
> returning an error code. However the value returned is (mostly)
> ignored
> and this typically results in resource leaks. To improve here there
> is a
> quest to make the remove callback return void. In the first step of
> this
> quest all drivers are converted to .remove_new() which already
> returns
> void.
>
> Trivially convert this driver from always returning zero in the
> remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Reviewed-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
Cheers,
-Paul
> ---
> drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
> b/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
> index ff26c10f295d..b9f135297aa0 100644
> --- a/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
> +++ b/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
> @@ -522,7 +522,7 @@ static int ingenic_nand_probe(struct
> platform_device *pdev)
> return 0;
> }
>
> -static int ingenic_nand_remove(struct platform_device *pdev)
> +static void ingenic_nand_remove(struct platform_device *pdev)
> {
> struct ingenic_nfc *nfc = platform_get_drvdata(pdev);
>
> @@ -530,8 +530,6 @@ static int ingenic_nand_remove(struct
> platform_device *pdev)
> ingenic_ecc_release(nfc->ecc);
>
> ingenic_nand_cleanup_chips(nfc);
> -
> - return 0;
> }
>
> static const struct jz_soc_info jz4740_soc_info = {
> @@ -564,7 +562,7 @@ MODULE_DEVICE_TABLE(of, ingenic_nand_dt_match);
>
> static struct platform_driver ingenic_nand_driver = {
> .probe = ingenic_nand_probe,
> - .remove = ingenic_nand_remove,
> + .remove_new = ingenic_nand_remove,
> .driver = {
> .name = DRV_NAME,
> .of_match_table = ingenic_nand_dt_match,
