On Thu, Feb 23, 2023 at 11:36:41AM +0000, Jiaxun Yang wrote: > dma_default_coherent was decleared unconditionally at kernel/dma/mapping.c > but only decleared when any of non-coherent options is enabled in dma-map-ops.h. Overly lone line here. > } > #else > +#define dma_default_coherent true > static inline bool dev_is_dma_coherent(struct device *dev) Please keep an empty line before the function declaration.