Re: [PATCH 2/4] gpio: loongson1: Introduce ls1x_gpio_chip struct

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Keguang Zhang <keguang.zhang@xxxxxxxxx>
Subject: Re: [PATCH 2/4] gpio: loongson1: Introduce ls1x_gpio_chip struct
From: andy.shevchenko@xxxxxxxxx
Date: Wed, 22 Feb 2023 14:18:22 +0200
Cc: linux-gpio@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Linus Walleij <linus.walleij@xxxxxxxxxx>, Bartosz Golaszewski <brgl@xxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>
In-reply-to: <20230222111213.2241633-3-keguang.zhang@gmail.com>
References: <20230222111213.2241633-1-keguang.zhang@gmail.com> <20230222111213.2241633-3-keguang.zhang@gmail.com>

Wed, Feb 22, 2023 at 07:12:11PM +0800, Keguang Zhang kirjoitti:
> Introduce and allocate ls1x_gpio_chip struct containing
> gpio_chip and reg_base to avoid global gpio_reg_base.
> 
> Use readl() & writel() instead of __raw_readl() & __raw_writel().

Please, split this to two pathes.

-- 
With Best Regards,
Andy Shevchenko

Follow-Ups:
- Re: [PATCH 2/4] gpio: loongson1: Introduce ls1x_gpio_chip struct
  - From: Kelvin Cheung

References:
- [PATCH 0/4] Devicetree support for Loongson-1 GPIO
  - From: Keguang Zhang
- [PATCH 2/4] gpio: loongson1: Introduce ls1x_gpio_chip struct
  - From: Keguang Zhang

Prev by Date: Re: [PATCH 4/4] dt-bindings: gpio: Add Loongson-1 GPIO
Next by Date: Re: [PATCH 3/4] gpio: loongson1: Add DT support
Previous by thread: [PATCH 2/4] gpio: loongson1: Introduce ls1x_gpio_chip struct
Next by thread: Re: [PATCH 2/4] gpio: loongson1: Introduce ls1x_gpio_chip struct
Index(es):
- Date
- Thread

[Index of Archives] [LKML Archive] [Linux ARM Kernel] [Linux ARM] [Git] [Yosemite News] [Linux SCSI] [Linux Hams]

Powered by Linux