On Tue, Feb 21, 2023 at 11:09 AM Arınç ÜNAL <arinc.unal@xxxxxxxxxx> wrote: > > On 21.02.2023 12:38, Sergio Paracuellos wrote: > > Hi Arınç, > > > > On Tue, Feb 21, 2023 at 10:24 AM <arinc9.unal@xxxxxxxxx> wrote: > >> > >> From: Arınç ÜNAL <arinc.unal@xxxxxxxxxx> > >> > >> Currently, out of every Ralink SoC, only the dt-binding of the MT7621 SoC > >> uses pinctrl. Because of this, PINCTRL is not selected at all. Make > >> SOC_MT7621 select PINCTRL. > >> > >> Remove PINCTRL_MT7621, enabling it for the MT7621 SoC will be handled under > >> the PINCTRL_MT7621 option. > >> > >> Signed-off-by: Arınç ÜNAL <arinc.unal@xxxxxxxxxx> > >> --- > >> arch/mips/ralink/Kconfig | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/arch/mips/ralink/Kconfig b/arch/mips/ralink/Kconfig > >> index 06031796c87b..83e61e147b90 100644 > >> --- a/arch/mips/ralink/Kconfig > >> +++ b/arch/mips/ralink/Kconfig > >> @@ -54,7 +54,7 @@ choice > >> select HAVE_PCI > >> select PCI_DRIVERS_GENERIC > >> select SOC_BUS > >> - select PINCTRL_MT7621 > >> + select PINCTRL > >> > >> help > >> The MT7621 system-on-a-chip includes an 880 MHz MIPS1004Kc > >> -- > >> 2.37.2 > >> > > > > Which git tree are you working against? CONFIG_SOC_MT7621 is not > > selecting PINCTRL_MT7621 at all in v6.2 [0]. I think it should select > > mips/linux.git mips-next tree. > > https://git.kernel.org/pub/scm/linux/kernel/git/mips/linux.git/log/ I see :). Thanks! > > > 'PINCTRL_MT7621' and the 'select PINCTRL' stuff added inside the > > PINCTRL_RALINK option in [1]. > > I'm working on that, although not exactly the way you describe here, on > this branch of mine. So, in which way do you get PINCTRL_MT7621 automatically selected for this SoC now? I think looking into the Kconfig for ralink pinctrl [0] all of them at the end need the missing PINCTRL option to be added and all of them are currently selecting PINCTRL_RALINK . Hence just adding the PINCTRL option inside PINCTRL_RALINK looks convenient. > > https://github.com/arinc9/linux/commits/ralink-pinctrl Wow! Tons of changes here ;-). Keep going!! > > Arınç Best regards, Sergio Paracuellos [0]: https://elixir.bootlin.com/linux/v6.2/source/drivers/pinctrl/ralink/Kconfig
