Re: [PATCH 10/22] mips/cpu: Make sure play_dead() doesn't return

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH 10/22] mips/cpu: Make sure play_dead() doesn't return
From: Florian Fainelli <f.fainelli@xxxxxxxxx>
Date: Mon, 6 Feb 2023 14:36:32 -0800
Cc: jgross@xxxxxxxx, richard.henderson@xxxxxxxxxx, ink@xxxxxxxxxxxxxxxxxxxx, mattst88@xxxxxxxxx, linux-alpha@xxxxxxxxxxxxxxx, linux@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, catalin.marinas@xxxxxxx, will@xxxxxxxxxx, guoren@xxxxxxxxxx, linux-csky@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, chenhuacai@xxxxxxxxxx, kernel@xxxxxxxxxx, loongarch@xxxxxxxxxxxxxxx, f.fainelli@xxxxxxxxx, bcm-kernel-feedback-list@xxxxxxxxxxxx, tsbogend@xxxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, jiaxun.yang@xxxxxxxxxxx, mpe@xxxxxxxxxxxxxx, npiggin@xxxxxxxxx, christophe.leroy@xxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, ysato@xxxxxxxxxxxxx, dalias@xxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, tglx@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, bp@xxxxxxxxx, dave.hansen@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, hpa@xxxxxxxxx, chris@xxxxxxxxxx, jcmvbkbc@xxxxxxxxx, linux-xtensa@xxxxxxxxxxxxxxxx, peterz@xxxxxxxxxxxxx, juri.lelli@xxxxxxxxxx, vincent.guittot@xxxxxxxxxx, dietmar.eggemann@xxxxxxx, rostedt@xxxxxxxxxxx, bsegall@xxxxxxxxxx, mgorman@xxxxxxx, bristot@xxxxxxxxxx, vschneid@xxxxxxxxxx, paulmck@xxxxxxxxxx
In-reply-to: <b131d3e00967034d86692b894a66c6a656e7de3f.1675461757.git.jpoimboe@kernel.org>
References: <cover.1675461757.git.jpoimboe@kernel.org> <b131d3e00967034d86692b894a66c6a656e7de3f.1675461757.git.jpoimboe@kernel.org>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2

On 2/3/23 14:05, Josh Poimboeuf wrote:

play_dead() doesn't return.  Make that more explicit with a BUG().

BUG() is preferable to unreachable() because BUG() is a more explicit
failure mode and avoids undefined behavior like falling off the edge of
the function into whatever code happens to be next.

Signed-off-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>


Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
--
Florian

References:
- [PATCH 00/22] cpu,sched: Mark arch_cpu_idle_dead() __noreturn
  - From: Josh Poimboeuf
- [PATCH 10/22] mips/cpu: Make sure play_dead() doesn't return
  - From: Josh Poimboeuf

Prev by Date: Re: [PATCH 09/22] mips/cpu: Expose play_dead()'s prototype definition
Next by Date: Re: [PATCH 11/22] mips/cpu: Mark play_dead() __noreturn
Previous by thread: [PATCH 10/22] mips/cpu: Make sure play_dead() doesn't return
Next by thread: [PATCH 09/22] mips/cpu: Expose play_dead()'s prototype definition
Index(es):
- Date
- Thread

[Index of Archives] [LKML Archive] [Linux ARM Kernel] [Linux ARM] [Git] [Yosemite News] [Linux SCSI] [Linux Hams]