On Fri, Nov 04, 2022 at 11:39:44AM +0800, Yang Yingliang wrote: > Afer commit 1fa5ae857bb1 ("driver core: get rid of struct device's > bus_id string array"), the name of device is allocated dynamically, > it need be freed when module exiting, call put_device() to give up > reference, so that it can be freed in kobject_cleanup() when the > refcount hit to 0. The vpe_device is static, so remove kfree() from > vpe_device_release(). > > Fixes: 1fa5ae857bb1 ("driver core: get rid of struct device's bus_id string array") > Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx> > --- > arch/mips/kernel/vpe-mt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/mips/kernel/vpe-mt.c b/arch/mips/kernel/vpe-mt.c > index bad6b0891b2b..84a82b551ec3 100644 > --- a/arch/mips/kernel/vpe-mt.c > +++ b/arch/mips/kernel/vpe-mt.c > @@ -313,7 +313,6 @@ ATTRIBUTE_GROUPS(vpe); > > static void vpe_device_release(struct device *cd) > { > - kfree(cd); > } as this is empty now, we can IMHO remove the function completly. Same for the other patch in this series. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]