Re: [PATCH 36/44] KVM: x86: Do compatibility checks when onlining CPU

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/3/22 18:44, Sean Christopherson wrote:
Do compatibility checks when enabling hardware to effectively add
compatibility checks when onlining a CPU.  Abort enabling, i.e. the
online process, if the (hotplugged) CPU is incompatible with the known
good setup.

This paragraph is not true with this patch being before "KVM: Rename and
move CPUHP_AP_KVM_STARTING to ONLINE section".

Argh, good eyes.  Getting the ordering correct in this series has been quite the
struggle.  Assuming there are no subtle dependencies between x86 and common KVM,
the ordering should be something like this:

It's not a problem to keep the ordering in this v1, just fix the commit message like "Do compatibility checks when enabling hardware to effectively add compatibility checks on CPU hotplug. For now KVM is using a STARTING hook, which makes it impossible to abort the hotplug if the new CPU is incompatible with the known good setup; switching to an ONLINE hook will fix this."

Paolo

   KVM: Opt out of generic hardware enabling on s390 and PPC
   KVM: Register syscore (suspend/resume) ops early in kvm_init()
   KVM: x86: Do compatibility checks when onlining CPU
   KVM: SVM: Check for SVM support in CPU compatibility checks
   KVM: VMX: Shuffle support checks and hardware enabling code around
   KVM: x86: Do VMX/SVM support checks directly in vendor code
   KVM: x86: Unify pr_fmt to use module name for all KVM modules
   KVM: x86: Use KBUILD_MODNAME to specify vendor module name
   KVM: Make hardware_enable_failed a local variable in the "enable all" path
   KVM: Use a per-CPU variable to track which CPUs have enabled virtualization
   KVM: Remove on_each_cpu(hardware_disable_nolock) in kvm_exit()
   KVM: Drop kvm_count_lock and instead protect kvm_usage_count with kvm_lock
   KVM: Disable CPU hotplug during hardware enabling
   KVM: Rename and move CPUHP_AP_KVM_STARTING to ONLINE section
   KVM: Drop kvm_arch_check_processor_compat() hook





[Index of Archives]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux