Re: [PATCH v6 2/2] dt-bindings: mips: brcm: add Broadcom SoCs bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 4, 2022 at 7:14 AM Rafał Miłecki <zajec5@xxxxxxxxx> wrote:
>
> On 4.10.2022 07:09, Sergio Paracuellos wrote:
> > Add the yaml binding for MIPS Broadcom cable/DSL/settop platforms.
> >
> > Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>
> > ---
> >   .../devicetree/bindings/mips/brcm/soc.yaml    | 98 +++++++++++++++++++
> >   1 file changed, 98 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/mips/brcm/soc.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/mips/brcm/soc.yaml b/Documentation/devicetree/bindings/mips/brcm/soc.yaml
> > new file mode 100644
> > index 000000000000..39b4609cd1cc
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mips/brcm/soc.yaml
> > @@ -0,0 +1,98 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mips/brcm/soc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Broadcom cable/DSL/settop platforms
> > +
> > +maintainers:
> > +  - Hauke Mehrtens <hauke@xxxxxxxxxx>
> > +  - Rafał Miłecki <zajec5@xxxxxxxxx>
> > +  - Florian Fainelli <f.fainelli@xxxxxxxxx>
>
> The only MIPS SoCs I really worked on were BCM47xx. I didn't do any real
> work on cable/DSL/STB.
>
> I don't really feel up to like maintaining those SoCs.

I can remove you from maintainers in this new file. I added you
because of this entry in MAINTAINERS file:

BROADCOM BCM47XX MIPS ARCHITECTURE
M:  Hauke Mehrtens <hauke@xxxxxxxxxx>
M:  Rafał Miłecki <zajec5@xxxxxxxxx>
L:  linux-mips@xxxxxxxxxxxxxxx
S:  Maintained
F:  Documentation/devicetree/bindings/mips/brcm/
F:  arch/mips/bcm47xx/*
F:  arch/mips/include/asm/mach-bcm47xx/*

Since 'Documentation/devicetree/bindings/mips/brcm/' is supposed to be
maintained also by you I thought it makes sense to list you also here.

I don't know, maybe you should remove yourself also from the
MAINTAINERS file for BROADCOM BCM47XX MIPS ARCHITECTURE???

Let me know what you want me to do.

Thanks,
    Sergio Paracuellos
>
>
> > +
> > +description: |
> > +    Boards Broadcom cable/DSL/settop SoC shall have the following properties.
> > +    The experimental -viper variants are for running Linux on the 3384's
> > +    BMIPS4355 cable modem CPU instead of the BMIPS5000 application processor.
> > +
> > +properties:
> > +  $nodename:
> > +    const: '/'
> > +
> > +  compatible:
> > +    enum:
> > +      - brcm,bcm3368
> > +      - brcm,bcm3384
> > +      - brcm,bcm33843
> > +      - brcm,bcm3384-viper
> > +      - brcm,bcm33843-viper
> > +      - brcm,bcm6328
> > +      - brcm,bcm6358
> > +      - brcm,bcm6362
> > +      - brcm,bcm6368
> > +      - brcm,bcm63168
> > +      - brcm,bcm63268
> > +      - brcm,bcm7125
> > +      - brcm,bcm7346
> > +      - brcm,bcm7358
> > +      - brcm,bcm7360
> > +      - brcm,bcm7362
> > +      - brcm,bcm7420
> > +      - brcm,bcm7425
> > +
> > +  cpus:
> > +    type: object
> > +    additionalProperties: false
> > +    properties:
> > +      '#address-cells':
> > +        const: 1
> > +
> > +      '#size-cells':
> > +        const: 0
> > +
> > +      mips-hpt-frequency:
> > +        description: MIPS counter high precision timer frequency.
> > +         This is common to all CPUs in the system so it lives
> > +         under the "cpus" node.
> > +        $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > +    patternProperties:
> > +      "^cpu@[0-9]$":
> > +        type: object
> > +        $ref: /schemas/mips/cpus.yaml#
> > +        unevaluatedProperties: false
> > +
> > +    required:
> > +      - mips-hpt-frequency
> > +
> > +additionalProperties: true
> > +
> > +examples:
> > +  - |
> > +     / {
> > +         compatible = "brcm,bcm3368";
> > +         #address-cells = <1>;
> > +         #size-cells = <1>;
> > +         model = "Broadcom 3368";
> > +
> > +         cpus {
> > +           #address-cells = <1>;
> > +           #size-cells = <0>;
> > +
> > +           mips-hpt-frequency = <150000000>;
> > +
> > +           cpu@0 {
> > +             compatible = "brcm,bmips4350";
> > +             device_type = "cpu";
> > +             reg = <0>;
> > +           };
> > +
> > +           cpu@1 {
> > +             compatible = "brcm,bmips4350";
> > +             device_type = "cpu";
> > +             reg = <1>;
> > +           };
> > +         };
> > +       };
> > +...
>




[Index of Archives]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux