On Fri, Sep 30, 2022 at 05:15:25PM +0200, Thomas Bogendoerfer wrote: > On Mon, Sep 26, 2022 at 09:59:00PM -0700, Dmitry Torokhov wrote: > > This patch switches the driver from legacy gpio API to the newer > > gpiod API. > > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > > --- > > v2 - actually compiles. > > I have some doubts... You are right, I am very sorry as I am not sure how that happened. I did indeed have a version with the exact errors you pointed out, and I fixed them. I am not sure how I managed to send the wrong one to you... I will send out the right one as v3, in the meantime here is what I see on my end with it: dtor@dtor-ws:~/kernel/cross-tmp ((b4938080955f...))$ date Fri Sep 30 08:46:26 AM PDT 2022 dtor@dtor-ws:~/kernel/cross-tmp ((b4938080955f...))$ git log -1 --abbrev --oneline HEAD b4938080955f (HEAD) MIPS: pci: lantiq: switch to using gpiod API dtor@dtor-ws:~/kernel/cross-tmp ((b4938080955f...))$ git show HEAD | git patch-id 2f4c9e4f56e674980122ce426c9ca9281eb393a1 b4938080955f015ffd1a8f778ce57b2a8e50c7ba dtor@dtor-ws:~/kernel/cross-tmp ((b4938080955f...))$ COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross -j1 O=./build_dir_mips ARCH=mips SHELL=/bin/bash arch/mips/pci/pci-lantiq.o Compiler will be installed in /usr/local/google/home/dtor/0day make --keep-going CONFIG_OF_ALL_DTBS=y CONFIG_DTC=y CROSS_COMPILE=/usr/local/google/home/dtor/0day/gcc-12.1.0-nolibc/mips-linux/bin/mips-linux- -j1 O=./build_dir_mips ARCH=mips SHELL=/bin/bash arch/mips/pci/pci-lantiq.o make[1]: Entering directory '/usr/local/google/home/dtor/kernel/cross-tmp/build_dir_mips' GEN Makefile CALL ../scripts/checksyscalls.sh CC arch/mips/pci/pci-lantiq.o CC arch/mips/pci/pci-lantiq.o make[1]: Leaving directory '/usr/local/google/home/dtor/kernel/cross-tmp/build_dir_mips' Thanks. -- Dmitry