On September 27, 2022 12:49:53 AM PDT, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> wrote: >On Mon, Sep 26, 2022 at 09:56:08PM -0700, Dmitry Torokhov wrote: >> Hi Thomas, >> >> On Sat, Sep 24, 2022 at 12:46:12PM +0200, Thomas Bogendoerfer wrote: >> > On Thu, Sep 22, 2022 at 09:55:40PM -0700, Dmitry Torokhov wrote: >> > > This switches vmmc to use gpiod API instead of OF-specific legacy gpio >> > > API that we want to stop exporting from gpiolib. >> > > >> > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> >> > > --- >> > > arch/mips/lantiq/xway/vmmc.c | 22 +++++++++++++--------- >> > > 1 file changed, 13 insertions(+), 9 deletions(-) >> > >> > applied to mips-next. >> >> My apologies, I screwed up. I thought this patch passed 0day before I >> sent it to you, but apparently it has not. >> >> Here is a fixup (actually cross-compiled this time), or I can send a v2 >> incorporating it into the original change. > >I need a fixup, but this one still fails in my build: > >/local/tbogendoerfer/korg/linux/arch/mips/lantiq/xway/vmmc.c: In function ‘vmmc_probe’: >/local/tbogendoerfer/korg/linux/arch/mips/lantiq/xway/vmmc.c:43:5: error: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘long int’ [-Werror=format=] > "failed to request GPIO idx %d: %d\n", > ^ I see, I did not realize PTR_ERR() is actually long. I guess I can introduce a temp variable and use PTR_ERR_OR_ZERO(), but there are a lot of places in the kernel that use %d and PTR_ERR(). I wonder why we can't define PTR_ERR() as (int)(long)ptr or something. What compiler/version are you using for your builds? Thanks. -- Dmitry
