Re: [PATCH] mips: ralink: mt7621: add device tree into the kernel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8.09.2022 09:08, Sergio Paracuellos wrote:
Device tree blobs for ralink mt7621 SoCs depends on configuration
CONFIG_SOC_MT7621 kernel option. This blobs needs to be properly
builtin into the kernel in order to be able to properly boot the
Gnubee boards. Hence, select CONFIG_BUILTIN_DTB for mt7621 Socs.
This option was a miss when this related device tree files were
moved from staging into the real 'arch/mips/boot/dts/ralink'
folder in kernel.

Fixes: 7a6ee0bbab25 ("mips: dts: ralink: add MT7621 SoC")
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>

I just tested this on a GB-PC2. If I understand correctly, this option adds all compiled DT on top of the compiled linux image, vmlinux, vmlinuz, etc..

DTB for GB-PC1 must come first since the bootloader on my GB-PC2 thinks the device is GB-PC1.

[ 0.000000] Linux version 6.0.0-rc3+ (arinc9@arinc9-PC) (mipsel-linux-gnu-gcc (Ubuntu 10.3.0-1ubuntu1) 10.3.0, GNU ld (GNU Binutils for Ubuntu) 2.38) #8 SMP Thu Sep 8 21:16:57 +03 2022
[    0.000000] SoC Type: MediaTek MT7621 ver:1 eco:3
[    0.000000] printk: bootconsole [early0] enabled
[    0.000000] CPU0 revision is: 0001992f (MIPS 1004Kc)
[    0.000000] MIPS: machine is GB-PC1

I think we should not make SOC_MT7621 select this option now that we compile devicetrees for all devices which use the MT7621 SoC but rather leave it to the OS builder, OpenWrt SDK, etc. to decide and add the DTB on top of the compiled linux image.

I think this is already the case for all arm devicetrees?

Arınç

---
  arch/mips/ralink/Kconfig | 1 +
  1 file changed, 1 insertion(+)

diff --git a/arch/mips/ralink/Kconfig b/arch/mips/ralink/Kconfig
index f9fe15630abb..f3b14bfc8066 100644
--- a/arch/mips/ralink/Kconfig
+++ b/arch/mips/ralink/Kconfig
@@ -54,6 +54,7 @@ choice
  		select HAVE_PCI
  		select PCI_DRIVERS_GENERIC
  		select SOC_BUS
+		select BUILTIN_DTB
help
  		  The MT7621 system-on-a-chip includes an 880 MHz MIPS1004Kc dual-core CPU,



[Index of Archives]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux