Hi, Arnd, On Thu, Jul 14, 2022 at 2:59 PM Arnd Bergmann <arnd@xxxxxxxx> wrote: > > On Thu, Jul 14, 2022 at 4:07 AM Huacai Chen <chenhuacai@xxxxxxxxx> wrote: > > On Tue, Jul 12, 2022 at 6:15 PM WANG Xuerui <kernel@xxxxxxxxxx> wrote: > > > On 2022/7/12 17:13, Geert Uytterhoeven wrote: > > > > > > But judging from the intent of this patch series (fixing WARNs on > > > certain configs), and that the triggering condition is currently > > > impossible on m68k (and other non-SMP) platforms, I think cleanups for > > > such arches could come as a separate patch series later. I think the > > > m68k refactoring is reasonable after all, due to my observation above, > > > but for the other non-SMP arches we may want to wait for the respective > > > maintainers' opinions. > > > > It seems that the best solution is only fix architectures with SMP > > support and leave others (m68k, microblaze, um) as is. :) > > I think it probably makes sense to do this as a combined cleanup patch, > which I can merge through the asm-generic tree, for all architectures > whose maintainer does not pick it up directly. For SMP architectures, > it's a bugfix that we probably want backported into stable kernels, while > for non-SMP targets it is just a minor cleanup for consistency. OK, I will send V2 later. Huacai > > Arnd
