On Wed, May 25, 2022 at 12:39:16PM +0800, Genjian Zhang wrote:
> From: huhai <huhai@xxxxxxxxxx>
>
> commit 979934da9e7a ("[PATCH] mips: update IRQ handling for vr41xx") added
> a function irq_dispatch, and it'll increase irq_err_count when the get_irq
> callback returns a negative value, but increase irq_err_count in get_irq
> was not removed.
>
> And also, modpost complains once gpio-vr41xx drivers become modules.
> ERROR: modpost: "irq_err_count" [drivers/gpio/gpio-vr41xx.ko] undefined!
>
> So it would be a good idea to remove repetitive increase irq_err_count in
> get_irq callback.
>
> Fixes: 27fdd325dace ("MIPS: Update VR41xx GPIO driver to use gpiolib")
> Fixes: 979934da9e7a ("[PATCH] mips: update IRQ handling for vr41xx")
> Reported-by: k2ci <kernel-bot@xxxxxxxxxx>
> Signed-off-by: huhai <huhai@xxxxxxxxxx>
This is missing your the Signed-off-by as submitter of the patch.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
