On Wed, 6 Apr 2022 at 13:11:25 +0200, Thomas Bogendoerfer wrote:
> On Tue, Apr 05, 2022 at 09:16:27PM -0700, Jakub Kicinski wrote:
> > The driver for ATM Ambassador devices spews build warnings on
> > microblaze. The virt_to_bus() calls discard the volatile keyword.
> > The right thing to do would be to migrate this driver to a modern
> > DMA API but it seems unlikely anyone is actually using it.
> > There had been no fixes or functional changes here since
> > the git era begun.
> >
> > In fact it sounds like the FW loading was broken from 2008
> > 'til 2012 - see commit fcdc90b025e6 ("atm: forever loop loading
> > ambassador firmware").
> >
> > Let's remove this driver, there isn't much changing in the APIs,
> > if users come forward we can apologize and revert.
> >
I contributed this driver (and the horizon one) over 20 years ago. I
doubt the hardware has been used in 20 years.
I just spoke today with David Miller about finally removing them and
found that you've already started.
Please remove horizon as well, analogously. Thanks!
> > Link: https://lore.kernel.org/all/20220321144013.440d7fc0@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
> > Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> > ---
> > CC: myxie@xxxxxxxxxx,gprocida@xxxxxxxxx
> > CC: Jesper Juhl <jj@xxxxxxxxxxxxx>
> > CC: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > CC: Chas Williams <3chas3@xxxxxxxxx> # ATM
> > CC: linux-atm-general@xxxxxxxxxxxxxxxxxxxxx
> > CC: tsbogend@xxxxxxxxxxxxxxxx # MIPS
> > CC: linux-mips@xxxxxxxxxxxxxxx
> > CC: p.zabel@xxxxxxxxxxxxxx # dunno why, get_maintainer
> > ---
> > arch/mips/configs/gpr_defconfig | 1 -
> > arch/mips/configs/mtx1_defconfig | 1 -
> > drivers/atm/Kconfig | 25 -
> > drivers/atm/Makefile | 1 -
> > drivers/atm/ambassador.c | 2400 ------------------------------
> > drivers/atm/ambassador.h | 648 --------
> > 6 files changed, 3076 deletions(-)
> > delete mode 100644 drivers/atm/ambassador.c
> > delete mode 100644 drivers/atm/ambassador.h
>
> Acked-by: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>
>
Acked-by: Giuliano Procida <gprocida@xxxxxxxxxx>
