On Tue, May 17, 2022 at 12:40:18AM -0700, Stephen Boyd wrote: > Quoting Serge Semin (2022-05-12 14:14:31) > > On Thu, May 12, 2022 at 10:41:50PM +0530, Manivannan Sadhasivam wrote: > > > On Thu, May 12, 2022 at 04:27:05PM +0100, Lorenzo Pieralisi wrote: > > > > So in short, this series has to go through the usual clock tree review > > > > process. > > > > > > > > I do know the normal procedure. But if patches concern different > > subsystems but for some reason inter-depended somehow it's ok to merge > > them in via a single repo. In my case the platform clock driver has > > been updated in a way so to support the reset-controls utilized in the > > PCIe driver altered in another patchset. So I didn't want to leave the > > kernel not working in the framework of my platform on any git hash > > state. That's why I asked to merge the patchsets in via the same repo. > > The kernel would be still buildable though. > > > > Is it going to be broken if I merge the clk patches through clk tree? No. It won't be broken. > Has it ever worked? It has and is working well except some minor fixes provided in this petchset: [PATCH v3 1/4] clk: baikal-t1: Fix invalid xGMAC PTP clock divider [PATCH v3 2/4] clk: baikal-t1: Define shared xGMAC ref/ptp clocks parent > Does the kernel still boot, just PCIe fails if the > patches are applied? Yes, the kernel will be bootable. There won't be any problem if the patches in this series are applied because it is self-consistent. As I said in the cover letter there is an implicit dependency of another series "[PATCH v2 00/17] PCI: dwc: Add dma-ranges/YAML-schema/Baikal-T1 support" (https://lore.kernel.org/linux-pci/20220503214638.1895-1-Sergey.Semin@xxxxxxxxxxxxxxxxxxxx/T/#me3c5c248adad9760702b545bd4bacd89d5f8a2bd) from this one. In particular the functionality implemented in the patch "[PATCH v2 17/17] PCI: dwc: Add Baikal-T1 PCIe controller support" (https://lore.kernel.org/linux-pci/20220503214638.1895-1-Sergey.Semin@xxxxxxxxxxxxxxxxxxxx/T/#m219e11c38c4ab8db0c2520c4050366d641598600) depends on the patches 3 and 4 of this patchset. But the dependency is implicit hidden under the DT clock/reset bindings layer. The Baikal-T1 PCIe platform driver will just fail to probe the host controller device if this series isn't applied. So the clock/reset patchset can be freely merged in via the clk tree especially seeing the PCIe Host/EP subsystem maintainer is going to be AFK from Wednesday and my series will sadly but likely hang up in limbo for a while. -Sergey
