Hi, > Am 12.04.2022 um 20:30 schrieb 周琰杰 (Zhou Yanjie) <zhouyanjie@xxxxxxxxxxxxxx>: > > Add the dwc2 bindings for the JZ4775 SoC, the JZ4780 SoC, the X1000 > SoC, the X1600 SoC, the X1700 SoC, the X1830 SoC, and the X2000 SoC > from Ingenic. > > Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@xxxxxxxxxxxxxx> > Acked-by: Rob Herring <robh@xxxxxxxxxx> > --- > > Notes: > v1->v2: > Add Rob Herring's Acked-by. > > Documentation/devicetree/bindings/usb/dwc2.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml > index 4cebce6..c6e8c0b 100644 > --- a/Documentation/devicetree/bindings/usb/dwc2.yaml > +++ b/Documentation/devicetree/bindings/usb/dwc2.yaml > @@ -17,6 +17,13 @@ properties: > oneOf: > - const: brcm,bcm2835-usb > - const: hisilicon,hi6220-usb > + - const: ingenic,jz4775-otg > + - const: ingenic,jz4780-otg > + - const: ingenic,x1000-otg > + - const: ingenic,x1600-otg > + - const: ingenic,x1700-otg > + - const: ingenic,x1830-otg > + - const: ingenic,x2000-otg I have merged it with my recently proposed removal of ingenic,jz4780-otg in jz4780.dtsi but there was no dtbscheck complaint about missing snps,dwc2. So I think should it be: - items: - enum: - const: ingenic,jz4775-otg - const: ingenic,jz4780-otg - const: ingenic,x1000-otg - const: ingenic,x1600-otg - const: ingenic,x1700-otg - const: ingenic,x1830-otg - const: ingenic,x2000-otg - const: snps,dwc2 similar to the entry for amlogic? > - items: > - const: rockchip,rk3066-usb > - const: snps,dwc2 > -- > 2.7.4 > BR and thanks, Nikolaus