> Am 09.04.2022 um 13:26 schrieb Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>: > > On 08/04/2022 20:37, H. Nikolaus Schaller wrote: >> jz4780-nemc needs to be compatible to simple-mfd as well or we get >> >> arch/mips/boot/dts/ingenic/ci20.dtb: memory-controller@13410000: compatible: 'oneOf' conditional failed, one must be fixed: >> ['ingenic,jz4780-nemc', 'simple-mfd'] is too long >> 'ingenic,jz4725b-nemc' was expected >> 'ingenic,jz4740-nemc' was expected >> From schema: Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml >> >> Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> >> --- >> .../devicetree/bindings/memory-controllers/ingenic,nemc.yaml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml b/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml >> index 24f9e19820282..3b1116588de3d 100644 >> --- a/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml >> +++ b/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml >> @@ -17,7 +17,7 @@ properties: >> oneOf: >> - enum: >> - >> - - ingenic,jz4780-nemc >> + - [ , simple-mfd ] > > This is not correct representation. If you really need simple-mfd, then > this should be a separate item below oneOf. Well, it is valid YAML syntax and seems to be accepted by dtbscheck. > The true question is whether you need simple-mfd. Isn't the binding (and > the driver) expected to instantiate its children? I had expected that but current ingenic,jz4780-nemc code doesn't. Everything is explained in 190607f2d59e174bcf8415efb1bb390737f8d428 But if someone writes a fix for the ingenic,jz4740-nemc driever we can of course live without this patch. And partially revert 190607f2d59e174bcf8415efb1bb390737f8d428
